More pytest optimizations - #3868
Merged
cdecker merged 10 commits intoAug 7, 2020
Merged
Conversation
rustyrussell
force-pushed
the
guilt/slow-tests-marked
branch
from
July 24, 2020 00:38
c28d9b5 to
a5b8034
Compare
rustyrussell
force-pushed
the
guilt/slow-tests-marked
branch
from
August 3, 2020 02:43
a5b8034 to
e5dd729
Compare
Contributor
Author
|
Trivial rebase |
I thought this was timing out because I made it slow with the change to txprepare as a plugin. In fact, it was timing out because sometimes gossip comes so fast it gets suppressed and we never get the log messags. Still, before this it took 98 seconds under valgrind and 24 under non-valgrind, so it's an improvement to time as well as robustness. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
…me of them. This lets you get_nodes() and join some later. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
This is what fund_channel() does, which is more thorough than what we were doing. But since the order of the logs is undefined, we need to be a little careful. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
In fact, the 5 blocks generate above were not seen by nodes until later, making me very confused. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell
force-pushed
the
guilt/slow-tests-marked
branch
from
August 4, 2020 20:51
e5dd729 to
be21b6b
Compare
Contributor
Author
|
Trivial rebase, and fix to actually turn off VALGRIND on slow tests! |
niftynei
approved these changes
Aug 7, 2020
|
|
||
| scid12 = l1.get_channel_scid(l2) | ||
| scid23 = l2.get_channel_scid(l3) | ||
| print(l1.rpc.getroute(l2.info['id'], 10000, 1)) |
We can have the message before the node ready message which line_graph waits for. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
We might have funds prior to calling join_nodes(), so testing that we've all seen the block is better. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
I started replacing all get_node() calls, but got bored, so then just did the tests which call get_node() 3 times or more. Ends up not making a measurable speed difference, but it does make some things neater and more standard. Times with SLOW_MACHINE=1 (given that's how Travis tests): Time before (non-valgrind): 393 sec (had 3 failures?) Time after (non-valgrind): 410 sec Time before (valgrind): 890 seconds (had 2 failures) Time after (valgrind): 892 sec Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
We can query all the txids at once, rather than one at a time. Doesn't make any measurable difference to full runtime testing here though. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Next patch will turn it off for slow-marked tests. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
And when it's set, and we're SLOW_MACHINE, simply disable valgrind. Since Travis (SLOW_MACHINE=1) only does VALGRIND=1 DEVELOPER=1 tests, and VALGRIND=0 DEVELOPER=0 tests, it was missing tests which needed DEVELOPER and !VALGRIND. Instead, this demotes them to non-valgrind tests for SLOW_MACHINEs. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell
force-pushed
the
guilt/slow-tests-marked
branch
from
August 7, 2020 03:15
be21b6b to
6c9d196
Compare
Member
|
ACK 6c9d196 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog-None